compiletest: show output in debug logging #148044
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
I had a test I was confused by; the root issue is that `error-pattern` runs before normalization, even though `//~ ERROR` runs after normalization. This logging caught the issue immediately.
jyn514
force-pushed
the
compiletest-logging
branch
from
d594e25 to
5976015
Compare
hkBst
reviewed
Oct 24, 2025
There was a problem hiding this comment.
This change simply adds output_to_check onto an existing debug log.
@jyn514 can you show an example of the change in output that results from this?
|
I’m vaguely worried about this being too verbose; how does the output look in practice? Maybe it’s actually fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a test I was confused by; the root issue is that
error-patternruns before normalization, even though//~ ERRORruns after normalization. This logging caught the issue immediately.